feat: gdb read write splitting#1243
Merged
Merged
Conversation
karenc-bq
force-pushed
the
feat/gdb-rw
branch
2 times, most recently
from
d2bf8d8 to
3ccc9b5
Compare
sophia-bq
approved these changes
Jun 9, 2026
| | `gdb_rw_home_region` | [GDB Read/Write Splitting Plugin](docs/using-the-python-wrapper/using-plugins/UsingTheGdbReadWriteSplittingPlugin.md) | | ||
| | `gdb_rw_restrict_writer_to_home_region` | [GDB Read/Write Splitting Plugin](docs/using-the-python-wrapper/using-plugins/UsingTheGdbReadWriteSplittingPlugin.md) | | ||
| | `gdb_rw_restrict_reader_to_home_region` | [GDB Read/Write Splitting Plugin](docs/using-the-python-wrapper/using-plugins/UsingTheGdbReadWriteSplittingPlugin.md) | | ||
| | `gdb_enable_global_write_forwarding` | [GDB Read/Write Splitting Plugin](docs/using-the-python-wrapper/using-plugins/UsingTheGdbReadWriteSplittingPlugin.md) | |
Contributor
There was a problem hiding this comment.
Not necessary for this PR but we should add a ticket to update this - it does not currently list all the properties
Contributor
Author
There was a problem hiding this comment.
Agreed. I do wonder if there are better formats to present all the parameters than this table though.
Contributor
There was a problem hiding this comment.
Agreed. I like the intention of it. One thing to explore is a decision tree for when to use which - this is particularly useful for global vs rds/aurora now that global has its own versions of many of the parameters
AhmadMasry
pushed a commit
to AhmadMasry/aws-advanced-python-wrapper
that referenced
this pull request
Jun 14, 2026
AhmadMasry
added a commit
to AhmadMasry/aws-advanced-python-wrapper
that referenced
this pull request
Jun 14, 2026
…parity) Async port of GdbReadWriteSplittingPlugin. Adds two override hooks to the async RWS base -- _select_reader_candidates (reader home-region restriction) and _should_switch_to_writer (writer home-region restriction / global write forwarding) -- mirroring sync _get_reader_host_candidates / _initialize_writer_connection / _set_writer_connection. AsyncGdbReadWriteSplit tingPlugin resolves the home region from gdb_rw_home_region or the connection host, keeps readers/writer in-region, and (with GWF enabled) keeps the current reader connection for a cross-region writer instead of failing. Registered as gdb_rw in the async plugin factory (weight 320, sync parity) and added to the topology-requiring set. Adds 10 unit tests; 1954 unit tests pass. NOTE: this completes the async gdb RWS plugin; the remaining full-parity infra (dialect flow through AsyncPluginService + AsyncGlobalAuroraTopologyMonitor) is follow-on work, validatable only against a real Global Database cluster.
AhmadMasry
added a commit
to AhmadMasry/aws-advanced-python-wrapper
that referenced
this pull request
Jun 14, 2026
The branch already contains all of origin/main's commits (merged earlier in 66fbcd4 and adopted: SQLAlchemy ORM support, gdb RWS aws#1243, initial_connection default plugins aws#1242, do_ping aws#1245, etc.). The Co-Authored-By trailer rewrite re-hashed those merged-in main commits, so git's ancestry counter showed the branch as '11 behind main' even though the content is present (verified). Use -s ours to re-link origin/main as an ancestor without altering the validated, integration-tested tree -- a content merge would instead re-add files we intentionally dropped (mysql_orm_dialect.py replaced by our sqlalchemy_dialects/) and re-surface already-resolved conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented GDB RW Splitting support.
Also included several changes:
.proxiedendpoints used in integration testsself._stale_dns_helper.notify_host_list_changed(changes)call in thefinallyblock in the failover pluginBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.